Fix autoSizeThatFits wrong calculations#221
Merged
Merged
Conversation
lucdion
approved these changes
Dec 10, 2020
lucdion
left a comment
lucdion
left a comment
Member
There was a problem hiding this comment.
Wow, thank you for this Nice fix
Member
|
@antoinelamy, would you mind checking this change? 🙏 |
Contributor
|
Yes I was looking at this bug and came with a similar solution as well but wanted to take more time to ensure it was not causing any other side effect. Will try to take the time soon. |
Member
|
@antoinelamy what is the risk of accepting this PR? From my point of view, it looks like a legit fix. What do you think could cause issues? |
Contributor
I investigated this last weekend and it look fine, we can merge this. Thanks @IgorBulyga for figuring this out. |
Member
|
Thanks @IgorBulyga @antoinelamy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I described in #220, there is a problem with size calculations of inner views while using
autoSizeThatFits. To make it works correctly we need just update autoSizingRect of each views before layout starts.There is example from ticket with this fix. As you can see it works as it should.
Fixed example
@antoinelamy Please check this fix.
Thank you.